fix(pipes): convert bytes using powers of 2 in TdBytesPipe. (closes #527)
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
w000t! awesome @aciccarello ! |
emoralesb05
changed the title
TdBytesPipe. (closes #527)
|
LGTM! Thanks dude! |
|
👍 |
ghost
self-requested a review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the TdBytesPipe to convert using 1024 bytes per Kilobyte (technically Kilibyte).
Closes #527
What's included?
Test Steps
General Tests for Every PR
ng serve --aotstill works. (Hung at 92% chunk asset optimization on local machine)npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to CodePen/Plunker/JSfiddle
Per #527 http://plnkr.co/edit/gLMsYWq064zvaN9FOl32