Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(): remove CovalentCoreModule since its been deprecated in beta.3 #539

Merged
merged 10 commits into from
May 5, 2017
Merged

chore(): remove CovalentCoreModule since its been deprecated in beta.3 #539

merged 10 commits into from
May 5, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Apr 29, 2017 •
edited by kyleledbetter
Loading

Description

Since we want people to import modules on a need basis, we deprecated the core module and now we are removing it from the code base.

What's included?

  • chore(docs): remove CovalentCoreModule mention in docs
  • feat(docs): remove CovalentCoreModule and only import needed modules

Test Steps

  • ng serve
  • Check that everything in the docs is working fine.

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added this to the Beta 4 milestone Apr 29, 2017
@kyleledbetter
Copy link
Contributor

when running npm test i got WARN: 'Could not find Angular Material core theme. Most Material components may not work as expected. For more info refer to the theming guide: https://material.angular.io/guide/theming' is that ok?

emoralesb05 added 2 commits May 2, 2017 20:26
@emoralesb05
Merge branch 'develop' into feature/core-removal
d664023
@emoralesb05
chore(): add material prebuilt theme in karma.conf.js
bbb2fb6 
this is needed to remove the warning for the material theme (need to add the covalent theme later on)
@emoralesb05
Copy link
Contributor Author

Just pushed a commit to remove that warning

richavyas
richavyas approved these changes May 3, 2017
View reviewed changes
Copy link
Collaborator

@richavyas richavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emoralesb05 emoralesb05 merged commit feb7cf7 into develop May 5, 2017
@emoralesb05 emoralesb05 deleted the feature/core-removal branch May 5, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richavyas richavyas richavyas approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
Beta 4
Development

Successfully merging this pull request may close these issues.
3 participants
@emoralesb05 @kyleledbetter @richavyas