Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(layout): remove deprecated selectors for ng-content #535

Merged
merged 2 commits into from
May 1, 2017

Conversation

emoralesb05
Copy link
Contributor

This selectors were deprecated a few releases back so it should be ok to remove them now

What's included?

  • Removal of ng-content selectors that were deprecated in beta.2

Test Steps

  • ng serve
  • See docs working fine since we stopped using them a long time ago.

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

This selectors were deprecated a few releases back so it should be ok to remove them now
@emoralesb05 emoralesb05 added this to the Beta 4 milestone Apr 29, 2017
@emoralesb05 emoralesb05 merged commit 9b0be9a into develop May 1, 2017
@emoralesb05 emoralesb05 deleted the feature/layout-selectors-removal branch May 1, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant