Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(getting-started): load our GETTING_STARTED.md in the docs (closes #504) #505

Merged
merged 3 commits into from
Apr 12, 2017

Conversation

emoralesb05
Copy link
Contributor

we need to show our GETTING_STARTED information easier by loading it in the docs site.

#504

What's included?

  • load our docs/ dir as part of the build.
  • Loading GETTING_STARTED.md with our pretty-markdown component

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

image

we need to show our GETTING_STARTED information easier by loading it in the docs site.
@emoralesb05 emoralesb05 changed the title chore(getting-started): load our GETTING_STARTED.md in the docs chore(getting-started): load our GETTING_STARTED.md in the docs (closes #504) Apr 12, 2017
@emoralesb05 emoralesb05 mentioned this pull request Apr 12, 2017
4 tasks
Copy link
Collaborator

@richavyas richavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emoralesb05 emoralesb05 merged commit 6f089fa into develop Apr 12, 2017
@emoralesb05 emoralesb05 deleted the feature/getting-started-docs branch April 12, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants