Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450) (closes #232) (closes #423) #482

Merged
merged 17 commits into from
Apr 5, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Apr 4, 2017

Description

#446
#450
#232
#423

Since we were leveraging @angular/material themes, we were using the scss files in their module, but this cause issues when using relative paths to node_modules or ~ (since ~ makes it tightly coupled to sass-loader/webpack)

Its better to just have the files internally and use those to avoid using ~.

What's included?

  • chore(scss): upgrade all internal sass style files to latest.
  • chore(): remove hardcoded background for md-list-avatar
  • chore(): remove hardcoded .mat-list-text p color
  • chore(): replace md-color by mat-color
  • fix(): remove ~ from highlight and markdown
  • fix(theming): use internal theme functions instead of materials
  • fix(validation): move hardcoded invalid input theme into common-theme

Test Steps

  • ng serve
  • See that all styles work fine

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added the bug label Apr 4, 2017
@emoralesb05 emoralesb05 added this to the Beta 3 milestone Apr 4, 2017
@emoralesb05 emoralesb05 changed the title feat(theming): use internal theme functions instead of materials. feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450) Apr 4, 2017
@emoralesb05 emoralesb05 changed the title feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450) feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450) (closes #232) (closes #423) Apr 4, 2017
@kyleledbetter kyleledbetter merged commit cc74bc1 into develop Apr 5, 2017
@kyleledbetter kyleledbetter deleted the feature/themes-upgrades branch April 5, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants