-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450) (closes #232) (closes #423) #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoralesb05
changed the title
feat(theming): use internal theme functions instead of materials.
feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450)
Apr 4, 2017
emoralesb05
changed the title
feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450)
feat(theming): use internal theme functions instead of materials. (closes #446) (closes #450) (closes #232) (closes #423)
Apr 4, 2017
This was referenced Apr 4, 2017
kyleledbetter
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#446
#450
#232
#423
Since we were leveraging
@angular/material
themes, we were using the scss files in their module, but this cause issues when using relative paths tonode_modules
or~
(since~
makes it tightly coupled tosass-loader
/webpack
)Its better to just have the files internally and use those to avoid using
~
.What's included?
Test Steps
ng serve
General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to CodePen/Plunker/JSfiddle