Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validations): remove input invalid style. #452

Closed
wants to merge 6 commits into from

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Mar 27, 2017

Description

Since [email protected] will have the invalid state, there is no more need for it.

What's included?

  • Removal of invalid state css in _input.scss.

Test Steps

  • ng serve
  • `See required invalid inputs still turn red.

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

@emoralesb05 emoralesb05 added this to the Beta 3 milestone Mar 27, 2017
@emoralesb05
Copy link
Contributor Author

emoralesb05 commented Mar 27, 2017

This should be merged/reviewed after material has been upgraded to beta.3

@emoralesb05 emoralesb05 changed the title feat(validations): remove input invalid style. (closes #232) (closes #423) fix(validations): remove input invalid style. Apr 4, 2017
@emoralesb05 emoralesb05 removed this from the Beta 3 milestone Apr 5, 2017
@emoralesb05
Copy link
Contributor Author

Closing since we will do this change in the beta.3 upgrade.

@emoralesb05 emoralesb05 deleted the feature/input-sass branch April 10, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant