Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ltr): add fallback styles for ltr + additional support. #413

Merged
merged 27 commits into from
Mar 16, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Mar 9, 2017

Description

Part of #323
Instead of assuming there will be a dir="ltr" or dir="rtl", there is a need to set defaults and then overrides when its dir="rtl", since there are use cases where devs wont use dir at all.

What's included?

  • feat(rtl): added default rules for ltr support with overriding rlt rules.
  • chore(rtl): polish usage of rtl
  • bugfix(rtl): fixed cases where rtl wasnt being applied.
  • feat(file-upload): added support for rtl.
  • feat(json-formatter): added somewhat support for rtl (there is still issues around the strings.
  • feat(search): added support for rtl.
  • feat(paging): added suport for rtl.
  • bugfix(notifications): fixed rtl support.
  • bugfix(data-table): fixed rtl support.

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

NOTE: we still need to figure out how to handle strings like Array [n] , etc etc in rtl

Also need to figure out how are we gonna handle rtl for utility classes like pad, push and pull

@emoralesb05 emoralesb05 changed the title feat(ltr): add fallback styles for ltr. feat(ltr): add fallback styles for ltr + additional support. Mar 10, 2017
@akhedrane
Copy link
Contributor

for utility classes, i think naming like pad-start & pad-end is more semantic.

@emoralesb05
Copy link
Contributor Author

@akhedrane yeah, i was actually thinking something like that or pad-before and pad-after to be inline with material

@kyleledbetter
Copy link
Contributor

We can leave the current left/right/top/bottom for explicit versions (they do this also in some places) and add additional before/after/above/below that are dynamic

@emoralesb05 emoralesb05 merged commit e270687 into develop Mar 16, 2017
@emoralesb05 emoralesb05 deleted the feature/rtl-polish branch March 16, 2017 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants