-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ltr): add fallback styles for ltr
+ additional support.
#413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lent into feature/rtl-polish
emoralesb05
changed the title
feat(ltr): add fallback styles for
feat(ltr): add fallback styles for Mar 10, 2017
ltr
.ltr
+ additional support.
for utility classes, i think naming like |
@akhedrane yeah, i was actually thinking something like that or |
We can leave the current left/right/top/bottom for explicit versions (they do this also in some places) and add additional before/after/above/below that are dynamic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #323
Instead of assuming there will be a
dir="ltr"
ordir="rtl"
, there is a need to set defaults and then overrides when itsdir="rtl"
, since there are use cases where devs wont usedir
at all.What's included?
ltr
support with overridingrlt
rules.rtl
rtl
wasnt being applied.rtl
.rtl
(there is still issues around the strings.rtl
.rtl
.rtl
support.rtl
support.Test Steps
ng serve
ltr
andrtl
General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.NOTE: we still need to figure out how to handle strings like
Array [n]
, etc etc inrtl
Also need to figure out how are we gonna handle
rtl
for utility classes likepad
,push
andpull