Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(chips): chips & autocomplete docs #395

Merged
merged 4 commits into from
Mar 2, 2017
Merged

docs(chips): chips & autocomplete docs #395

merged 4 commits into from
Mar 2, 2017

Conversation

richavyas
Copy link
Collaborator

@richavyas richavyas commented Feb 28, 2017 •
edited by emoralesb05
Loading

Description

Docs updated to show demo & code both in tabs

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

chips-docs

@richavyas
Copy link
Collaborator Author

  • Changed the layout to show separate blocks
  • updated the gif

emoralesb05
emoralesb05 approved these changes Mar 2, 2017
View reviewed changes
Copy link
Contributor

@emoralesb05 emoralesb05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emoralesb05 emoralesb05 merged commit 1561ff8 into develop Mar 2, 2017
@emoralesb05 emoralesb05 deleted the feature/chip-autocomplete-docs branch March 2, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoralesb05 emoralesb05 emoralesb05 approved these changes

Assignees
No one assigned
Labels
docs enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richavyas @emoralesb05