Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): date pipes were not working on safari #380

Merged
merged 2 commits into from
Feb 28, 2017
Merged

fix(docs): date pipes were not working on safari #380

merged 2 commits into from
Feb 28, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

Fixed date formats so the pipes can work on every browser.

Test Steps

  • ng serve
  • Get on safari
  • Check pipe documentation with timeAgo and timeDifference.

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

@emoralesb05 emoralesb05 added this to the Beta 3 milestone Feb 25, 2017
richavyas
richavyas approved these changes Feb 27, 2017
View reviewed changes
Copy link
Collaborator

@richavyas richavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emoralesb05 emoralesb05 merged commit 977e5ad into develop Feb 28, 2017
@emoralesb05 emoralesb05 deleted the feature/pipe-docs-fix branch February 28, 2017 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richavyas richavyas richavyas approved these changes

Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
Beta 3
Development

Successfully merging this pull request may close these issues.
2 participants
@emoralesb05 @richavyas