Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(digits): l10n support for TdDigitsPipe #378

Merged
merged 4 commits into from
Feb 28, 2017
Merged

Conversation

emoralesb05
Copy link
Contributor

Description

leverage LOCALE_ID and DecimalPipe to support l10n within TdDigitsPipe and update unit tests
#324

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

es:
image

en:
image

leverage LOCALE_ID and DecimalPipe to support l10n within TdDigitsPipe and update unit tests
@emoralesb05 emoralesb05 changed the title feat(digits): i10n support for TdDigitsPipe feat(digits): l10n support for TdDigitsPipe Feb 25, 2017
@emoralesb05 emoralesb05 added this to the Beta 3 milestone Feb 25, 2017
Copy link
Collaborator

@richavyas richavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richavyas richavyas merged commit b060c78 into develop Feb 28, 2017
@richavyas richavyas deleted the feature/l10n-digits branch February 28, 2017 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants