Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(paging-bar): removed hardcoded strings for i18n. (closes #356) and (closes #214) #365

Merged
merged 9 commits into from
Feb 23, 2017
Merged

feature(paging-bar): removed hardcoded strings for i18n. (closes #356) and (closes #214) #365

merged 9 commits into from
Feb 23, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Feb 22, 2017 •
edited by ilsiepotamus
Loading

Description

This is part of the epic #324 to support i18n in all covalent components.

Addresses #356 and #214

What's included?

  • feat(paging-bar): add [initialPage] input.
  • ** BREAKING CHANGE ** feat(paging-bar): abstract hardcoded text for i18n
  • docs(paging-bar): update docs, demo and README.md

Usage

<td-paging-bar #pagingBar pageSizeAllText="All"  [pageSizeAll]="true" [initialPage]="1">
  <span td-paging-bar-label hide-xs>Row per page:</span>
  {{pagingBar.range}} <span hide-xs>of {{pagingBar.total}}</span>
</td-paging-bar>

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

emoralesb05 added 5 commits February 22, 2017 07:42
feat(paging-bar): add initialPage input.
cec15b4 
input to initialize the component at a certain page.
feat(paging-bar): abstract hardcoded text for i18n
2ee1f06 
add td-paging-bar-label and generic ng-content for `range` of `total` and any other strings
docs(paging-bar): update docs and demo.
5783357 
update docs and demo with new usage of paging-bar plus code examples
docs(demos): update usage of paging-bar in other demos
a5e826d
docs(paging-bar): update README.md
277f3e7
@ilsiepotamus
Copy link
Contributor

👍

@emoralesb05 emoralesb05 added this to the Beta 2 milestone Feb 22, 2017
@kyleledbetter
Copy link
Contributor

Pushed tweaks to markup:
image

kyleledbetter
kyleledbetter approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@kyleledbetter kyleledbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyleledbetter kyleledbetter merged commit e454b98 into develop Feb 23, 2017
@kyleledbetter kyleledbetter deleted the feature/paging-enhancements branch February 23, 2017 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilsiepotamus ilsiepotamus ilsiepotamus approved these changes

@kyleledbetter kyleledbetter kyleledbetter approved these changes

Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
Beta 2
Development

Successfully merging this pull request may close these issues.
3 participants
@emoralesb05 @ilsiepotamus @kyleledbetter