feature(highlight): enhancements and code-health. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the content so content new lines arent removed
…Sanitizer to prevent XSS issues.
…tent dynamically.
…y default in covalent-highlight-theme
kyleledbetter
approved these changes
Jan 22, 2017
6 tasks
mrjasonweaver
approved these changes
Jan 23, 2017
| }); | ||
| }))); | ||
|
|
||
| it('should render cpde from dynamic content', async(inject([], () => { |
| @@ -20,7 +20,7 @@ By default, `--dev` build will log the following message in the console to let y | |||
|
|
|||
| This component can be installed as npm package. | |||
|
|
|||
| ```npm | |||
| ```bash | |||
There was a problem hiding this comment.
this works on windows also? should this say bash?
There was a problem hiding this comment.
bash is the language used to apply color theme in GitHub
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Major enhancements, initial unit tests and XSS protection.
What's included?
[content]input to load code content dynamically.highlight.jstheme.VS Dark+theme as closely as possible when importingcovalent-highlight-theme.Rendererto limit access to native DOM andDomSanitizerto preventXSSissues.htmlworkaround so code parsing is more generic now andhtmlis properly displayed.README.mdand demo.README.mdas resource in docs to avoid doc duplication.Test Steps
ng serveorng serve --aot --prodREADME.mdand new default theme.npm run testnpm run lintnpm run buildScreenshots or link to CodePen/Plunker/JSfiddle