Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(serve): "ng serve --aot" broken from test file (closes #267) #269

Merged
merged 3 commits into from
Jan 20, 2017

Conversation

jeremysmartt
Copy link
Collaborator

@jeremysmartt jeremysmartt commented Jan 19, 2017

Description

Adding exclusion of spec test files when running ng serve --aot
See bug: #267

What's included?

  • modified: src/tsconfig.json

Test Steps

  • checkout feature/bug217-ng-serve-aot-broken branch
  • run ng serve --aot
  • see that server starts up and can go to http://localhost:4200

@jeremysmartt jeremysmartt changed the title Fix for bug#267 - ng serve --aot broken bugfix(serve): for ng serve --aot broken (closes #267) Jan 19, 2017
@jeremysmartt jeremysmartt changed the title bugfix(serve): for ng serve --aot broken (closes #267) bugfix(serve): "ng serve --aot" broken from test file (closes #267) Jan 19, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.38% when pulling 2b9172e on feature/bug217-ng-serve-aot-broken into 3a15e7a on develop.

}
},
"exclude": [
"**/*.spec.*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor one but this can be specific => "**/*.spec.ts"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.38% when pulling 9363935 on feature/bug217-ng-serve-aot-broken into 3a15e7a on develop.

@richavyas richavyas merged commit 069e3fc into develop Jan 20, 2017
@richavyas richavyas deleted the feature/bug217-ng-serve-aot-broken branch January 20, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants