-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(loading): loading enhancements + re-haul to use material modules. (closes #255) (closes #84) #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue 0 when removed
… + OnPush change detection + easier fullscreen config.
…ing the name in `resolve`/`register`
…med ILoadingOptions -> ITdLoadingConfig
emoralesb05
changed the title
feature(loading): loading enhancements + re-haul to use material modules.
feature(loading): loading enhancements + re-haul to use material modules. (closes #255) (closes #84)
Jan 17, 2017
It would be nice if:
is the breaking change: Renamed ILoadingOptions into ITdLoadingConfig absolutely necessary? :) |
…adata/covalent into feature/loading-enhancements
kyleledbetter
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code re-haul of loading.module for enhancements and better usage + unit tests + better demos.
#255
#84
What's included?
tdFadeInOut
animation and used it instead oftdFade
directive.OnPush
strategy.Deprecate
ILoadingOptions
in favor ofITdLoadingConfig
Deprecate
createOverlayComponent()
method fromTdDialogService
in favor ofcreate()
Deprecate
loadingType
andloadingMode
in favor oftdLoadingType
andtdLoadingMode
so the inputs can be used correctly in (*) syntax. e.g.*tdLoading="'name'; type:'linear'"
TemplatePortal
andOverlay
frommaterial
.TdLoadingFactory
for internal usage only.tdLoadingStrategy
to change betweenoverlay
andreplace
strat. [Feature Request] Loading Overlay Component Target #84tdLoadingColor
input forprimary
,accent
orwarn
color="primary" is hard coded in td-loading component #255TdLoadingDirective
andTdLoadingService
Test Steps
ng serve
npm run tslint
npm test
and see code coverage now.npm run build
Before unit tests:
After unit tests:
Screenshots or link to CodePen/Plunker/JSfiddle