Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(loading): loading enhancements + re-haul to use material modules. (closes #255) (closes #84) #259

Merged
merged 33 commits into from
Jan 18, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Jan 17, 2017

Description

Code re-haul of loading.module for enhancements and better usage + unit tests + better demos.
#255
#84

What's included?

  • feature(animations): Added tdFadeInOut animation and used it instead of tdFade directive.
  • feature(loading): Easier fullscreen loading creation + default fullscreen mask.
  • feature(loading): Better efficiency with OnPush strategy.
  • Deprecate ILoadingOptions in favor of ITdLoadingConfig
  • Deprecate createOverlayComponent() method from TdDialogService in favor of create()
  • Deprecate loadingType and loadingMode in favor of tdLoadingType and tdLoadingMode so the inputs can be used correctly in (*) syntax. e.g. *tdLoading="'name'; type:'linear'"
  • refactor(loading): Leverage TemplatePortal and Overlay from material.
  • refactor(loading): separated code into creation (factory) and execution (service), and made TdLoadingFactory for internal usage only.
  • feature(loading): Added tdLoadingStrategy to change between overlay and replace strat. [Feature Request] Loading Overlay Component Target #84
  • feature(loading): Added tdLoadingColor input for primary , accent or warn color="primary" is hard coded in td-loading component #255
  • internal(loading): Better error messages.
  • internal(loading): More code blocks in methods.
  • docs(loading): Better demo and examples.
  • code-health(loading): unit tests for TdLoadingDirective and TdLoadingService

Test Steps

Before unit tests:

image

image

After unit tests:

image

image

Screenshots or link to CodePen/Plunker/JSfiddle

image

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 69.945% when pulling 4486fbf on feature/loading-enhancements into e382f16 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.2%) to 77.275% when pulling af098ab on feature/loading-enhancements into e382f16 on develop.

@emoralesb05 emoralesb05 added this to the Beta 1 milestone Jan 17, 2017
@emoralesb05 emoralesb05 changed the title feature(loading): loading enhancements + re-haul to use material modules. feature(loading): loading enhancements + re-haul to use material modules. (closes #255) (closes #84) Jan 17, 2017
@kyleledbetter
Copy link
Contributor

kyleledbetter commented Jan 17, 2017

It would be nice if:

  • the top demo had some loader running by default
  • the Register buttons read Toggle Loader

is the breaking change: Renamed ILoadingOptions into ITdLoadingConfig absolutely necessary? :)

@coveralls
Copy link

Coverage Status

Coverage increased (+6.2%) to 77.275% when pulling 8a72478 on feature/loading-enhancements into 9499741 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.2%) to 77.275% when pulling d6e83d0 on feature/loading-enhancements into 9499741 on develop.

@kyleledbetter kyleledbetter merged commit d87aa65 into develop Jan 18, 2017
@kyleledbetter kyleledbetter deleted the feature/loading-enhancements branch January 18, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants