Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(angular-cli): upgrade to beta.25-5 and fix ng lint usage #254

Merged
merged 2 commits into from
Jan 16, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Jan 14, 2017

Description

Upgrade to use latest angular-cli in covalent docs.
https://github.com/angular/angular-cli/blob/master/CHANGELOG.md#bug-fixes

Test Steps

  • rm -rf node_modules tmp dist deploy and npm i
  • ng serve and ng serve --aot --prod
  • ng build and ng build --aot --prod
  • ng lint or npm run lint (same thing now)
  • npm run test (which runs ng test --code-coverage --single-run)

@emoralesb05 emoralesb05 added this to the Beta 1 milestone Jan 14, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.27% when pulling 955741e on feature/upgrade-cli into c50155a on develop.

@mrjasonweaver mrjasonweaver self-requested a review January 16, 2017 19:25
Copy link
Contributor

@mrjasonweaver mrjasonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.07% when pulling e2a1f1f on feature/upgrade-cli into da4db7f on develop.

@richavyas richavyas merged commit e382f16 into develop Jan 16, 2017
@richavyas richavyas deleted the feature/upgrade-cli branch January 16, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants