Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(json-formatter): enhancements and bugfixes (closes #247) #250

Merged
merged 10 commits into from
Jan 15, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Jan 13, 2017

Description

Enhancements and bugfixes for json-formatter module.

What's included?

  • feature(json-formatter): add collapse animation to json-formatter
  • feature(json-formatter): use mdTooltip instead of title
  • feature(json-formatter): Improved efficiency by changing its change detection to OnPush + added refresh method for explicit change detection.
  • code-health(json-formatter): added initial unit tests for json-formatter
  • bugfix(json-formatter): recreate children array so it doesnt append the new children data. (closes JSON Formatter appends new object instead of show new object only. #247)
  • update docs and README.md

Test Steps

Before unit tests:
image

image

After unit tests:
image

image

Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added this to the Beta 1 milestone Jan 13, 2017
@emoralesb05 emoralesb05 changed the title Feature/json formatter enhancements Feature/json formatter enhancements. (closes #247) Jan 13, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 68.686% when pulling 266a40c on feature/json-formatter-enhancements into 48cdbca on develop.

@emoralesb05 emoralesb05 changed the title Feature/json formatter enhancements. (closes #247) feature(json-formatter): enhancements and bugfixes (closes #247) Jan 13, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 70.476% when pulling 2a63aeb on feature/json-formatter-enhancements into 48cdbca on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 71.07% when pulling 4037761 on feature/json-formatter-enhancements into 8015a67 on develop.

@kyleledbetter
Copy link
Contributor

any concerns with a super long object/info in the tooltip? there's improvements coming from material2 but they currently don't handle long text too well

@kyleledbetter
Copy link
Contributor

Ok i answered my own question, looks like it truncates w/ ... 👍

@kyleledbetter kyleledbetter merged commit da4db7f into develop Jan 15, 2017
@emoralesb05 emoralesb05 deleted the feature/json-formatter-enhancements branch January 16, 2017 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Formatter appends new object instead of show new object only.
3 participants