-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(json-formatter): enhancements and bugfixes (closes #247) #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etection to OnPush.
…he new children data.
emoralesb05
changed the title
Feature/json formatter enhancements
Feature/json formatter enhancements. (closes #247)
Jan 13, 2017
emoralesb05
changed the title
Feature/json formatter enhancements. (closes #247)
feature(json-formatter): enhancements and bugfixes (closes #247)
Jan 13, 2017
any concerns with a super long object/info in the tooltip? there's improvements coming from material2 but they currently don't handle long text too well |
Ok i answered my own question, looks like it truncates w/ ... 👍 |
kyleledbetter
approved these changes
Jan 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancements and bugfixes for
json-formatter
module.What's included?
collapse
animation tojson-formatter
mdTooltip
instead oftitle
refresh
method for explicit change detection.json-formatter
Test Steps
ng serve
npm run test
and see the before and after for code-coverage.Before unit tests:
After unit tests:
Screenshots or link to CodePen/Plunker/JSfiddle