-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(notifications): initial notifications module. (closes #148) #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…radata/covalent into feature/notifications-initial
…input in [notifications] (true or > 1)
Its actually always there, we just hide it when we focus the input. We can revisit this in a different PR or open an issue to check if that is confusing or something. |
I pointed out the placement, not visible/hide. First time when search is clicked, it's placed correctly inside the input box. During second time, the text is shifted upwards. |
Cool, could you please open an issue to keep track of it? |
emoralesb05
changed the title
feature(notifications): initial notifications module
feature(notifications): initial notifications module. closes(#148)
Dec 29, 2016
emoralesb05
changed the title
feature(notifications): initial notifications module. closes(#148)
feature(notifications): initial notifications module. (closes #148)
Dec 29, 2016
kyleledbetter
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing new core submodule
notifications
module. (CovalentNotificationsModule
) #148Adding core submodule
menu
for internal usage.<td-notification-count>
Use element to show number of notifications.
Properties:
Usage
Test Steps
ng serve
npm run test
npm run tslint
npm run build
Screenshots or link to CodePen/Plunker/JSfiddle