Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(notifications): initial notifications module. (closes #148) #213

Merged
merged 34 commits into from
Dec 30, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Dec 28, 2016

Description

Introducing new core submodule notifications module. (CovalentNotificationsModule) #148

Adding core submodule menu for internal usage.

<td-notification-count>

Use element to show number of notifications.

Properties:
image

Usage

  <td-notification-count color="primary | accent | warn" [notifications]="boolean | number">
     ... // could be an icon <md-icon>notifications</md-icon> or empty
  </td-notification-count>

Test Steps

Screenshots or link to CodePen/Plunker/JSfiddle

image

image

@kyleledbetter
Copy link
Contributor

pushed updates
notifications

@emoralesb05
Copy link
Contributor Author

emoralesb05 commented Dec 29, 2016

  • Created inner td-menu (composition vs inheritance) for better layout inside md-menu
     <md-menu #notificationsMenu="mdMenu">
        <td-menu>
          <div td-menu-header class="md-title pad-sm text-center">Notifications</div>
          <md-nav-list dense>
            <template let-last="last" ngFor [ngForOf]="[0,1,2,3,4]">
              <a md-list-item>
                <md-icon md-list-avatar>today</md-icon>
                <h3 md-line>Example notification here.</h3>
                <p md-line>Action</p>
                <span>23m</span>
              </a>
              <md-divider md-inset *ngIf="!last"></md-divider>
            </template>
          </md-nav-list>
          <button td-menu-footer md-raised-button color="accent">
            See All Notifications
          </button>
        </td-menu>
      </md-menu>

image

@emoralesb05
Copy link
Contributor Author

  • scss fix for notification-count
  • Added more usage cases for notification-count

image

@emoralesb05
Copy link
Contributor Author

  • Added noCount attribute to show a smaller notification

<td-notification-count color="accent" noCount [notifications]="true">

image

@richavyas
Copy link
Collaborator

observed an issue with search box placeholder Search:
scenario:

  • click on search, write some text, close it, click on search sign again and check the search placeholder placement.

screen shot 2016-12-29 at 11 50 18 am

@emoralesb05
Copy link
Contributor Author

emoralesb05 commented Dec 29, 2016

Its actually always there, we just hide it when we focus the input. We can revisit this in a different PR or open an issue to check if that is confusing or something.

@richavyas
Copy link
Collaborator

I pointed out the placement, not visible/hide. First time when search is clicked, it's placed correctly inside the input box. During second time, the text is shifted upwards.

@emoralesb05
Copy link
Contributor Author

Cool, could you please open an issue to keep track of it?

@emoralesb05 emoralesb05 changed the title feature(notifications): initial notifications module feature(notifications): initial notifications module. closes(#148) Dec 29, 2016
@emoralesb05 emoralesb05 changed the title feature(notifications): initial notifications module. closes(#148) feature(notifications): initial notifications module. (closes #148) Dec 29, 2016
@kyleledbetter kyleledbetter merged commit 746fe3c into develop Dec 30, 2016
@emoralesb05 emoralesb05 deleted the feature/notifications-initial branch December 30, 2016 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants