feature(http): improvements on http module. closes (#179) #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a need to be able to override the service
transform
in the RESTService at a method level. So now you can pass a specifictransform
callback that overrides the service leveltransform
function.#179
What's included?
IRestTransform
callback to allow more flexibility on response transformationsonRequestError
hook to theIHttpInterceptor
interface and usage inHttpInterceptorService
(upstreamed from AC)code-health
unit test toRESTService
Test Steps
There is no real way to test it without actually using it, so the
unit-tests
should check if theRESTService
acts like it should on every scenario.ng serve
http
moduleng serve
to see test theRESTService
with itshttp-rest.service.spec.ts