Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(http): improvements on http module. closes (#179) #192

Merged
merged 15 commits into from
Dec 19, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Dec 14, 2016

Description

There is a need to be able to override the service transform in the RESTService at a method level. So now you can pass a specific transform callback that overrides the service level transform function.
#179

What's included?

  • REST Methods now accept an extra optional parameter for method level IRestTransform callback to allow more flexibility on response transformations
  • Added new onRequestError hook to the IHttpInterceptor interface and usage in HttpInterceptorService (upstreamed from AC)
  • Added code-health unit test to RESTService
  • Updated docs and README.md

Test Steps

There is no real way to test it without actually using it, so the unit-tests should check if the RESTService acts like it should on every scenario.

  • ng serve
  • See updated docs in http module
  • ng serve to see test the RESTService with its http-rest.service.spec.ts

@emoralesb05 emoralesb05 added this to the Alpha 0.10 milestone Dec 14, 2016
@kyleledbetter kyleledbetter merged commit d73badb into develop Dec 19, 2016
@emoralesb05 emoralesb05 deleted the feature/http-improvements branch December 19, 2016 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants