Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(dialogs): better a11y + exposed open/closeAll methods from MdDialog. closes(#170 and #171) #190

Merged
merged 5 commits into from
Dec 16, 2016
Merged

feature(dialogs): better a11y + exposed open/closeAll methods from MdDialog. closes(#170 and #171) #190

merged 5 commits into from
Dec 16, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Dec 13, 2016 •
edited by kyleledbetter
Loading

Description

Added better a11y support for confirm and prompt dialogs.
#170
Added open() and closeAll() methods into TdDialogService to allow MdDialog underlying usage of both methods without having to inject MdDialog.
#171

screen shot 2016-12-12 at 10 56 08 pm

Test Steps

@emoralesb05 emoralesb05 added this to the Alpha 0.10 milestone Dec 13, 2016
@emoralesb05 emoralesb05 changed the title feature(dialogs): better a11y + service access to open/closeAll methods from MdDialog. feature(dialogs): better a11y + exposed open/closeAll methods from MdDialog. closes(#170 and #171) Dec 13, 2016
@kyleledbetter kyleledbetter merged commit f6bc829 into develop Dec 16, 2016
@emoralesb05 emoralesb05 deleted the feature/dialog-improvements branch December 16, 2016 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement ux lgtm
Projects
None yet
Milestone
Alpha 0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@emoralesb05 @kyleledbetter