Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): format columns correctly when displaying them. closes(#187) #188

Merged
merged 6 commits into from
Dec 16, 2016
Merged

fix(data-table): format columns correctly when displaying them. closes(#187) #188

merged 6 commits into from
Dec 16, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Dec 13, 2016 •
edited by kyleledbetter
Loading

Description

Switched the way we format the column values in the data-table component to be on display, so the underlying data is not modified nor copied.
#187

Test Steps

Screenshots or link to CodePen/Plunker/JSfiddle

image

@emoralesb05 emoralesb05 added this to the Alpha 0.10 milestone Dec 13, 2016
@emoralesb05 emoralesb05 changed the title fix(data-table): format columns correctly when displaying them. closes(#187) fix(data-table): format columns correctly when displaying them. closes(https://github.com/Teradata/covalent/issues/187) Dec 13, 2016
@emoralesb05 emoralesb05 changed the title fix(data-table): format columns correctly when displaying them. closes(https://github.com/Teradata/covalent/issues/187) fix(data-table): format columns correctly when displaying them. closes(#187) Dec 13, 2016
@jeremysmartt jeremysmartt self-assigned this Dec 13, 2016
@emoralesb05
Copy link
Contributor Author

  • Added validation to properly handle empty (undefined) data

@kyleledbetter
Copy link
Contributor

Does the example HTML & TS need updating also?

image

@emoralesb05
Copy link
Contributor Author

Well, we didnt need to, but i guess it doesnt hurt to show how they can do it with the atomic components 😛 pushed~

@kyleledbetter kyleledbetter merged commit 66ab3f6 into develop Dec 16, 2016
@emoralesb05 emoralesb05 deleted the feature/dt-format branch December 16, 2016 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeremysmartt jeremysmartt

Labels
code lgtm ux lgtm
Projects
None yet
Milestone
Alpha 0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@emoralesb05 @kyleledbetter @jeremysmartt