Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stepper enhancements #145

Merged
merged 11 commits into from
Nov 18, 2016
Merged

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Nov 10, 2016

Description

Stepper enhacements to be more inline with md-tab-group/md-tab and bug fixes.

What's included?

  • Removed [td-step-content]template and make step content anything inside of it (except templates for label, summary and actions). This fixes the issue where you couldnt reference an element (e.g. #form) inside the td-step-content template from another template (e.g td-step-actions)
  • Support for label template template[td-step-label] as an alternative while keeping the easy API [label] input for normal (simple) use cases in td-step
  • Update demo and docs.

Usag

 <td-step #step label="Label" sublabel="Sublabel" [active]="active" [disabled]="disabled" [state]="state" (activated)="activeEvent()" (deactivated)="deactiveEvent()">
          <template td-step-label>
            ... add label content (if not used, falls back to [label] input)
          </template>
          ... add content that will be shown when the step is "active"
          <template td-step-actions>
            <button (click)="step.close()">Close</button>
            ... add button elements for the step content (optional)
          </template>
          <template td-step-summary>
            ... add summary that will be shown when step in is "complete" state (optional)
          </template>
        </td-step>     

Test Steps

  • npm i
  • ng serve
  • Check step demo

Question: Should we rename td-steps to td-step-group?

@kyleledbetter kyleledbetter merged commit 5d87249 into develop Nov 18, 2016
@emoralesb05 emoralesb05 deleted the feature/stepper-enhancements branch November 18, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants