Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Adding Documentation for sorting by date #1225

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

jeremysmartt
Copy link
Collaborator

@jeremysmartt jeremysmartt commented Aug 17, 2018

Description

Several bugs written about sorting by date on datatable. Adding documentation to show how.
closes #674
closes #461
closes #521

What's included?

  • src/app/components/components/data-table/data-table.component.html
  • src/app/components/components/data-table/data-table.component.ts

Test Steps

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:lib still works.
Screenshots or link to StackBlitz/Plunker

date sort

@jeremysmartt jeremysmartt added this to the Release 2.0.0 milestone Aug 17, 2018
@jennmedellin jennmedellin self-requested a review August 17, 2018 22:00
Copy link
Collaborator

@jennmedellin jennmedellin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM

Copy link
Collaborator

@JulieMarie JulieMarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jeremysmartt jeremysmartt merged commit 9f47043 into develop Aug 23, 2018
@jeremysmartt jeremysmartt deleted the fix/tablecolumn-date-sort-674 branch August 23, 2018 16:40
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants