feat(tab-select): initial implementation for tab select *experimental* #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first pass on tab select component and will be treated as experimental while we use it in multiple products to ensure quality
JulieMarie
requested changes
Jul 6, 2018
| @@ -0,0 +1,3 @@ | |||
| <ng-template> | |||
| <ng-content></ng-content> | |||
| </ng-template> | |||
There was a problem hiding this comment.
Will the extra special characters cause any problems?
There was a problem hiding this comment.
Maybe these aren't a problem...I see them on test-bed.component.html as well.
There was a problem hiding this comment.
what extra special characters?
There was a problem hiding this comment.
Weird....they are gone now.
| + Disables ripple effect on component. | ||
| + color?: ThemePalette | ||
| + Color of the tab group. | ||
| + backgroundColor: ThemePalette |
There was a problem hiding this comment.
Is backgroundColor optional or required?
JulieMarie
reviewed
Jul 6, 2018
| MY LABEL 3 | ||
| </td-tab-option> | ||
| </td-tab-select> | ||
| </div> |
There was a problem hiding this comment.
But still down here. ;-)
JulieMarie
approved these changes
Jul 6, 2018
jeremysmartt
requested changes
Jul 9, 2018
| MY LABEL 3 | ||
| </td-tab-option> | ||
| </td-tab-select> | ||
| </div> |
There was a problem hiding this comment.
no example with disabledRipple, do we care?
jeremysmartt
approved these changes
Jul 10, 2018
|
|
|
Will be taken care of in #1191 |
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
Teradata#1187) * feat(tab-select): initial implementation for tab select *experimental* first pass on tab select component and will be treated as experimental while we use it in multiple products to ensure quality * docs(tab-select): make backgroundColor optional in README * chore(tab-select): add initial set of unit tests * feat(): add disabled ripple on tabs for test-bed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First pass on tab select component and will be treated as experimental while we use it in multiple products to ensure quality.
Usage:
What's included?
Test Steps
npm run serve:test-bedGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.Screenshots or link to StackBlitz/Plunker
closes #1178