Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): upgrade from ng-packager v2.0.0 to v2.4.2 #1137

Merged
merged 13 commits into from
Apr 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2018

Description

Upgrade from ng-packager v2.0.0 to v2.4.2 we obtain a few important feature such as:
support intra-package dependencies (secondary intra-entry point support, doesn't look like primary intra-entry point is supported yet), allow Angular 6 as a peer dependency, and more.

What's included?

  • Upgrade from ng-packager v2.0.0 to v2.4.2

Test Steps (Covalent build/test)

  • Verify you are using node v8.9.x
  • To make the next steps a little easier go to scripts/build-release and add this code to the bottom of the file to npm pack instead of doing it manually:
cd deploy/platform/core
npm pack
cd ../dynamic-forms
npm pack
cd ../highlight
npm pack
cd ../http
npm pack
cd ../markdown
npm pack

Test Steps (Product build)

  • Clone AppCenter repo into the directory above this one.
  • yarn cache clean
  • yarn install
  • yarn remove @covalent/core
  • yarn remove @covalent/highlight
  • yarn remove @covalent/http
  • yarn remove @covalent/markdown
  • yarn add <file-path-to-*.tgz> repeat for (core, highlight, http, markdown respectively) (EX: yarn add ../covalent/deploy/platform/core/covalent-core-0.0.0-COVALENT.tgz)
  • npm rebuild node-sass
  • Verify you are using node v8.9.x.
  • Verify npm run serve works correctly
  • Verify ./node_modules/@angular/cli/bin/ng build --aot --prod --sourcemap=false --build-optimizer successfully runs
  • Verify ./node_modules/@angular/cli/bin/ng serve --aot --prod --sourcemap=false --build-optimizer --proxy-config proxy.conf.json successfully runs and you can access the local site http://localhost:4200/
  • Modify the import paths (primary/secondary entry point usage) in app.module and try the prod build again it should run successfully.
  • Using similar steps above try it on a different product that is using covalent (WLA, ect..), make sure to remove the current node_module/@covalent/* before installing the packages from this repo.

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:lib still works.
Screenshots or link to StackBlitz/Plunker

@ghost ghost added the in progress label Apr 9, 2018
@ghost ghost removed the dont merge label Apr 10, 2018
@emoralesb05 emoralesb05 merged commit 6d2d741 into develop Apr 12, 2018
@emoralesb05 emoralesb05 deleted the feature/upgrade-ng-packagr branch April 12, 2018 22:18
@ghost ghost removed the ready for review label Apr 16, 2018
@ghost ghost changed the title chore(): upgrade from ng-packager v2.0.0 to v2.4.1 chore(): upgrade from ng-packager v2.0.0 to v2.4.2 Apr 16, 2018
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
* chore(): upgrade from ng-packager v2.0.0 to v2.4.1

* refactor(): echo message change

* fix(): test travis script changes

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): test mod travis-script

* fix(): upgrade ng-packagr to v2.4.2 to resolve npm installation bug ng-packagr/ng-packagr#754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant