-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): upgrade from ng-packager v2.0.0 to v2.4.2 #1137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
in progress
label
Apr 9, 2018
ghost
removed
the
dont merge
label
Apr 10, 2018
ghost
removed
the
ready for review
label
Apr 16, 2018
ghost
changed the title
chore(): upgrade from ng-packager v2.0.0 to v2.4.1
chore(): upgrade from ng-packager v2.0.0 to v2.4.2
Apr 16, 2018
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* chore(): upgrade from ng-packager v2.0.0 to v2.4.1 * refactor(): echo message change * fix(): test travis script changes * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): test mod travis-script * fix(): upgrade ng-packagr to v2.4.2 to resolve npm installation bug ng-packagr/ng-packagr#754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade from ng-packager v2.0.0 to v2.4.2 we obtain a few important feature such as:
support intra-package dependencies (secondary intra-entry point support, doesn't look like primary intra-entry point is supported yet), allow Angular 6 as a peer dependency, and more.
What's included?
Test Steps (Covalent build/test)
scripts/build-release
and add this code to the bottom of the file tonpm pack
instead of doing it manually:npm run serve
works accordingly. Test all components http://localhost:4200/npm run build:lib
Test Steps (Product build)
yarn cache clean
yarn install
yarn remove @covalent/core
yarn remove @covalent/highlight
yarn remove @covalent/http
yarn remove @covalent/markdown
yarn add <file-path-to-*.tgz>
repeat for (core, highlight, http, markdown respectively) (EX:yarn add ../covalent/deploy/platform/core/covalent-core-0.0.0-COVALENT.tgz
)npm rebuild node-sass
npm run serve
works correctly./node_modules/@angular/cli/bin/ng build --aot --prod --sourcemap=false --build-optimizer
successfully runs./node_modules/@angular/cli/bin/ng serve --aot --prod --sourcemap=false --build-optimizer --proxy-config proxy.conf.json
successfully runs and you can access the local site http://localhost:4200/General Tests for Every PR
npm run serve:prod
still works.npm run tslint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build:lib
still works.Screenshots or link to StackBlitz/Plunker