Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): fix covalent build in case typeCheck is used in apps #1117

Merged
merged 1 commit into from
Feb 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@
"lint": "npm run tslint && npm run stylelint",
"tslint": "./node_modules/.bin/tslint --format codeFrame -c ./tslint.json \"./src/**/*.ts\" -e \"./src/**/typings.d.ts\" -e \"./src/environments/**\"",
"stylelint": "./node_modules/.bin/stylelint 'src/**/*.scss' '!**/_layout.scss' '!**/markdown.component.scss' --config .stylelintrc.json --syntax scss",
"postinstall": "webdriver-manager update",
"reinstall": "rm -rf node_modules tmp deploy dist && yarn install && npm rebuild node-sass",
"reinstall:latest": "rm -rf node_modules tmp deploy dist && npm install",
"preinstall": "rm -rf node_modules tmp deploy dist",
"postinstall": "npm rebuild node-sass && webdriver-manager update",
"test": "ng test --code-coverage --single-run --sourcemap=false",
"coverage:win": "start chrome ./coverage/index.html",
"coverage:mac": "open -a \"Google Chrome\" coverage/index.html",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Component, HostBinding, ChangeDetectionStrategy } from '@angular/core';
})
export class CardOverComponent {

routes: Object[] = [{
routes: any[] = [{
icon: 'home',
route: '.',
title: 'Home',
Expand Down
2 changes: 1 addition & 1 deletion src/platform/core/common/pipes/time-ago/time-ago.pipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Pipe, PipeTransform } from '@angular/core';
name: 'timeAgo',
})
export class TdTimeAgoPipe implements PipeTransform {
transform(time: any, reference: any): string {
transform(time: any, reference?: any): string {
// Convert time to date object if not already
time = new Date(time);
let ref: Date = new Date(reference);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Pipe, PipeTransform } from '@angular/core';
})

export class TdTimeDifferencePipe implements PipeTransform {
transform(start: any, end: any): string {
transform(start: any, end?: any): string {
let startTime: Date = new Date(start);
let endTime: Date;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class TdDataTableColumnComponent {
/**
* Listening to click event on host to throw a sort event
*/
@HostListener('click', ['event'])
@HostListener('click')
handleClick(): void {
if (this.sortable) {
this.onSortChange.emit({name: this.name, order: this._sortOrder});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class TdDataTableRowComponent {
/**
* Listening to click event to explicitly focus the row element.
*/
@HostListener('click', ['$event'])
@HostListener('click')
clickListener(): void {
this.focus();
}
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compileOnSave": false,
"compilerOptions": {
"baseUrl": "./src",
"declaration": false,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
Expand Down