fix(): products ng build/serve --prod build issue #1104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The most recent version of covalent at the time of this writing v1.0.0-rc.3 converted Covalent distribution to Angular package format. Products that used this new dist was failing when running
--prod
flag onng serve
andng build
commands.What's included?
--prod
flag usage on products consuming Covalent (issue was invalidcovalent-core.metadata.json
generating from ngc usage inside ngpackagr which is used for aot when using the--prod
flag).Test Steps (Covalent build)
npm run reinstall
scripts/build-release
and add this code to the bottom of the file tonpm pack
instead of doing it manually:npm run build:release
Test Steps (Product build)
yarn install
yarn remove @covalent/core
yarn add <file-path-to-*.tgz>
(EX:yarn add ../covalent/deploy/platform/core/covalent-core-1.0.0-rc.3.tgz
)npm rebuild node-sass
yarn upgrade @angular/material
./node_modules/@angular/cli/bin/ng build --aot --prod --sourcemap=false --build-optimizer
successfully runs./node_modules/@angular/cli/bin/ng serve --aot --prod --sourcemap=false --build-optimizer --proxy-config proxy.conf.json
successfully runs and you can access the local site http://localhost:4200/General Tests for Every PR
npm run serve:prod
still works.npm run tslint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build:release
still works.closes #1099