-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore()/update patterns to stackblitz #1064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add stackblitz example - Modify layout to match new patterns
- Remove example logic from cards - Rework alert pattern
- update management list example to stackblitz - fix layout
- update ts
- update mgmt list & nav drawer pattern layouts & examples
- cleanup all layouts
- Clean up guidance
jennmedellin
changed the title
chore()/update cards pattern
chore()/update patterns to stackblitz
Jan 24, 2018
- Add [inset]="true" on MatDividers - Fix Do's and Don'ts (lost in code conflict)
- make all typography divs include relative class
- remove unused css
kyleledbetter
approved these changes
Jan 25, 2018
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* chore()/update cards pattern - Add stackblitz example - Modify layout to match new patterns * chore()/update patterns - Remove example logic from cards - Rework alert pattern * chore()/update mgmt list - update management list example to stackblitz - fix layout * chore()/update mgmt list - update ts * chore()/update patterns - update mgmt list & nav drawer pattern layouts & examples * chore()/update layouts - cleanup all layouts * chore()/clean up - Clean up guidance * chore(docs): update patterns - Add [inset]="true" on MatDividers - Fix Do's and Don'ts (lost in code conflict) * chore(docs)/update patterns to stackblitz - make all typography divs include relative class * chore(docs)/update to stackblitz - remove unused css * chore(patterns): fix dividers & lists * chore(theme): fix link style * chore(patterns): add missing dividers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existing patterns layouts to match new ones and move demo to Stackblitz.
Description
What's included?
Test Steps
npm run serve
General Tests for Every PR
npm run serve:prod
still works.npm run tslint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build:release
still works.Screenshots or link to StackBlitz/Plunker