Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore()/update patterns to stackblitz #1064

Merged
merged 16 commits into from
Jan 25, 2018
Merged

Conversation

jennmedellin
Copy link
Collaborator

@jennmedellin jennmedellin commented Jan 3, 2018

Update existing patterns layouts to match new ones and move demo to Stackblitz.

Description

  • Add stackblitz example
  • Modify layout to match new patterns

What's included?

  • Cards
  • Alerts
  • Management List
  • Nav Drawer

Test Steps

  • npm run serve
  • then open each pattern & verify the Stackblitz loads
  • finally verify guidance

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:release still works.
Screenshots or link to StackBlitz/Plunker

- Add stackblitz example
- Modify layout to match new patterns
jm186140 added 6 commits January 3, 2018 13:07
- Remove example logic from cards
- Rework alert pattern
- update management list example to stackblitz
- fix layout
- update mgmt list & nav drawer pattern layouts & examples
- cleanup all layouts
- Clean up guidance
@emoralesb05 emoralesb05 modified the milestones: Release Candidate 3, Next Release Jan 17, 2018
@jennmedellin jennmedellin changed the title chore()/update cards pattern chore()/update patterns to stackblitz Jan 24, 2018
- Add [inset]="true" on MatDividers
- Fix Do's and Don'ts (lost in code conflict)
@kyleledbetter kyleledbetter merged commit eb72cc4 into develop Jan 25, 2018
@kyleledbetter kyleledbetter deleted the chore/patterns-layout branch January 25, 2018 23:11
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
* chore()/update cards pattern

- Add stackblitz example
- Modify layout to match new patterns

* chore()/update patterns

- Remove example logic from cards
- Rework alert pattern

* chore()/update mgmt list

- update management list example to stackblitz
- fix layout

* chore()/update mgmt list

- update ts

* chore()/update patterns

- update mgmt list & nav drawer pattern layouts & examples

* chore()/update layouts

- cleanup all layouts

* chore()/clean up

- Clean up guidance

* chore(docs): update patterns

- Add [inset]="true" on MatDividers
- Fix Do's and Don'ts (lost in code conflict)

* chore(docs)/update patterns to stackblitz

- make all typography divs include relative class

* chore(docs)/update to stackblitz

- remove unused css

* chore(patterns): fix dividers & lists

* chore(theme): fix link style

* chore(patterns): add missing dividers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants