feat(chips): add inputPosition input to change its position to before or after (closes #990)
#1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r before position
jeremysmartt
requested changes
Jan 3, 2018
There was a problem hiding this comment.
Trying to do npm run build:release
gives:
[13:30:32] 'rollup-code' errored after 541 ms
[13:30:32] Error: Octal literal in strict mode
at error (/Users/js186150/Documents/public/covalent/node_modules/rollup/dist/rollup.js:170:12)
at Module.error$1 [as error] (/Users/js186150/Documents/public/covalent/node_modules/rollup/dist/rollup.js:8007:2)
at tryParse (/Users/js186150/Documents/public/covalent/node_modules/rollup/dist/rollup.js:7710:10)
at new Module (/Users/js186150/Documents/public/covalent/node_modules/rollup/dist/rollup.js:7745:14)
at /Users/js186150/Documents/public/covalent/node_modules/rollup/dist/rollup.js:9495:17
|
Fixed the build and linter. So everything should be fine now. |
jeremysmartt
approved these changes
Jan 4, 2018
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
…re or after (closes Teradata#990) (Teradata#1061) * feat(chips): add `inputPosition` input to change its position to before or after * feat(chips): add unit test to see if the class gets properly added for before position * chore(): move rtl mark to jsonformatter theme since build is failing when css is inside compiled js * chore(): fix stylelint issue * chore(): fix build error for covalent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To allow a bit more flexibility, we added a new input to change where the input is going to be positioned.. whether is before or after the list of chips regardless if its stacked or not.
What's included?
[inputPosition]input withbeforeandaftervaluesTest Steps
npm run serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:releasestill works.Screenshots or link to StackBlitz/Plunker
closes #990