Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): support OnPush change detection strat #1032

Merged
merged 1 commit into from
Dec 15, 2017
Merged

feat(search): support OnPush change detection strat #1032

merged 1 commit into from
Dec 15, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

Making sure td-search-box and td-search-input work on OnPush change detection strat.

Test Steps

  • npm run serve
  • Go to search demo
  • See it working on OnPush

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run lint passes.

@emoralesb05 emoralesb05 added this to the Release Candidate 2 milestone Dec 13, 2017
@emoralesb05 emoralesb05 merged commit 5e35c5e into develop Dec 15, 2017
@emoralesb05 emoralesb05 deleted the feature/search-push-det branch December 15, 2017 00:54
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
@emoralesb05
feat(search): add OnPush support (Teradata#1032)
97ad122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release Candidate 2
Development

Successfully merging this pull request may close these issues.
1 participant
@emoralesb05