Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(build): move to a single package #93

Closed
quanterion opened this issue Oct 4, 2016 · 3 comments
Closed

feature(build): move to a single package #93

quanterion opened this issue Oct 4, 2016 · 3 comments
Milestone
Alpha 0.10

Comments

@quanterion
Copy link
Contributor

Are you considering publish covalent as a single package as has been done by Angular Material team here angular/components#1286?
@emoralesb05
Copy link
Contributor

We are thinking about it since we want to follow the same standards as material2. We are just trying to tackle other priorities first before deciding to do that.

@emoralesb05 emoralesb05 mentioned this issue Nov 22, 2016
Closed
@emoralesb05
Copy link
Contributor

We decided to bundle everything that makes sense under core.

So the only modules that would be stand alone would be:

highlight and markdown since they use 3rd party js libs,
http since the focus of it is different.
core (with everything else on it)

@emoralesb05 emoralesb05 added this to the Alpha 0.10 milestone Dec 16, 2016
@emoralesb05 emoralesb05 mentioned this issue Dec 19, 2016
Merged
4 tasks
kyleledbetter pushed a commit that referenced this issue Dec 20, 2016
@emoralesb05 @kyleledbetter
*BREAKING CHANGE* feature(deploy): single core package. closes(#166 and
81901b2 
#93) (#201)

* created NucleusModule with animations, forms and pipes in it

* stop exporting directive constants

* fixed imports/exports for rollup build (nucleus)

* added dialogs.module

* added expansion-panel.module

* added layout.module

* added loading.module

* added media.module

* added steps.module

* moved data-table.module into core.module

* update docs to state you can pull the module separatly or  inside Core

* added chips.module inside core.module

* missed a few imports for chips.module

* added file.module into core.mocule

* added json-formatter.module into core.module

* added paging.module into core.module

* remove charts from theming

* extracted markdown from core theming

* reorg styles and theming

* pullled search.module into core.module

* fixed demo imports to `core` and changed location of markdown-theme

* renamed nuclues.module into common.module

* fixed theming path

* adde TD_FORMS directives into common.module

* added theming for charts (back)
@emoralesb05
Copy link
Contributor

Done with #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Alpha 0.10
Development

No branches or pull requests
2 participants
@emoralesb05 @quanterion