Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TdMediaService doesn't trigger Portrait or Lanscape #922

Closed
pmullot opened this issue Oct 8, 2017 · 0 comments · Fixed by #938
Closed

TdMediaService doesn't trigger Portrait or Lanscape #922

pmullot opened this issue Oct 8, 2017 · 0 comments · Fixed by #938
Assignees
Labels

Comments

@pmullot
Copy link

pmullot commented Oct 8, 2017

Do you want to request a feature or report a bug?

BUG

Bug Report

mediaService.query('landscape') is never triggered due to bad specification in media.service.js

What is the expected behavior?

Screen Orientation change should trigger a true match

Which version of Angular and Material, and which browser and OS does this issue affect?

 "@covalent/core": "^1.0.0-beta.7"

Did this work in previous versions of Angular / Material?
Nothing to do with angular

Other information

Problem can be solved by changing lines 22 & 23 of media.service.js
this._queryMap.set('landscape', 'landscape');
this._queryMap.set('landscape','(orientation: landscape)');

this._queryMap.set('portrait', 'portrait');
this._queryMap.set('portrait', '(orientation: portrait)');

@emoralesb05 emoralesb05 added this to the Release Candidate 0 milestone Oct 11, 2017
@jeremysmartt jeremysmartt self-assigned this Oct 16, 2017
jeremysmartt pushed a commit that referenced this issue Oct 19, 2017
emoralesb05 pushed a commit that referenced this issue Oct 20, 2017
…ape (#938)

* bugfix(mediaService): Fix for TdMediaService doesn't trigger Portrait or Lanscape

closes #922

* feat(): add better media query demo to showcase breakpoints

* chore(): add note to media query demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants