File upload response status check and response parsing to JSON.

[saurabh1e]

Bug Report

File: covalent/core/file/services/file.service.js

xhr.onreadystatechange = function () {
                if (xhr.readyState === 4) {
                    if (xhr.status === 200 || xhr.status === 201) {
                        subscriber.next(JSON.parse(xhr.response));
                        subscriber.complete();
                    }
                    else {
                        subscriber.error(xhr.response);
                    }
                }
            };

1. Status should be checked for >= 200 and < 300.
2. Response should be returned with out parsing in JSON.

What is the expected behavior?

xhr.onreadystatechange = function () {
                if (xhr.readyState === 4) {
                    if (xhr.status >= 200 && xhr.status < 300) {
                        subscriber.next(xhr.response);
                        subscriber.complete();
                    }
                    else {
                        subscriber.error(xhr.response);
                    }
                }
            };

What is the motivation / use case for changing the behavior?

I am trying to upload file to AWS S3 which is returning 204 and response in XML. This will fix the issue.

[emoralesb05]

Can you open a small PR with this fix please? 😄

[saurabh1e]

Sure! I will do that.