Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD-Dynamic-Forms: ERROR Error: Cannot find control with name: 'el04' #624

Closed
pabloxn opened this issue May 25, 2017 · 4 comments · Fixed by #787
Closed

TD-Dynamic-Forms: ERROR Error: Cannot find control with name: 'el04' #624

pabloxn opened this issue May 25, 2017 · 4 comments · Fixed by #787
Assignees
Milestone

Comments

@pabloxn
Copy link

pabloxn commented May 25, 2017

BUG

Bug Report

I have a form that previews the forms as you build it. When I enter the first element I have no problem - but every subsequent entries after that have the error:

ERROR Error: Cannot find control with name: 'el04'

If I load the saved form it works fine - only seems to be a problem for adding on the fly.

screen shot 2017-05-25 at 12 50 22

What is the expected behavior?

to add controls without falling over

@emoralesb05
Copy link
Contributor

so you are adding another element on the fly and it fails?

@pabloxn
Copy link
Author

pabloxn commented May 25, 2017

yup - sorry if I wasn't clear

@emoralesb05
Copy link
Contributor

Cool, no worries 😄

Just wanted to get all the info i could to understand the use case.

@jerryorta-dev jerryorta-dev self-assigned this Jul 5, 2017
jerryorta-dev pushed a commit that referenced this issue Jul 25, 2017
…g runtime

Refactored form controls to use FormArray API to add, edit, and remove controls.

closes #624
jerryorta-dev pushed a commit that referenced this issue Jul 25, 2017
At runtime, have the ability to dynamically add, edit, remove Form Controls

closes #624
@emoralesb05
Copy link
Contributor

This will be fixed in beta.7 but it will be needed to call a new introduced refresh method when modifying anything in the element array

emoralesb05 pushed a commit that referenced this issue Aug 9, 2017
* fix(dynamic-forms): #624 dynamically add, edit, remove Form Controls

At runtime, have the ability to dynamically add, edit, remove Form Controls

closes #624

* fix(dynamic-forms): #624 add validateDynamicElementName back

* chore(): simplify code by adding/removing controls and forcing a manual update

manual updates are great since checking if an array or its content has changes can be expensive in the long run, and most of the time not needed.. adding a refresh method gives the power to the developer to rerender the form if needed.

* chore(dynamic-forms): load README.md and add refresh method to its API

* feat(dynamic-forms): make flex width % configurable via element interface

* feat(dynamic-forms): support OnPush change detection

* feat(dynamic-forms): add demo to build your own form

* fix(dynamic-forms): add small fix for times where the control is created a bit later

* feat(dynamic-forms): add valid submit button to demo

* chore(dynamic-forms): add comments to code

* docs(dynamic-forms): new side-by-side pattern
@emoralesb05 emoralesb05 added this to the Beta.7 milestone Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants