-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates and Styles not inlined in NPM packages #27
Comments
Hey @mbellezi We dont want to do a custom solution (search and replace with code) in the building process like angular2-material since it will only be temporary. But if it takes too long for an official solution to come and people need it, we might have to revisit this. |
Ok. Until a solution is not available, I will manually import the platform/core folder from the Covalent github project as it is in Typescript. The NPM can't be used without a preprocessing step. |
It's the standard I've seen to reference compiled CSS in styleUrls, and we try to follow the official material2 repo as closely as possible like: https://github.com/angular/material2/blob/master/src/components/button/button.ts#L29 on the topic SCSS however, I've opened an issue to ship the SCSS and CSS in case you'd want to pull in the source SCSS files in your app #28 |
html and styles inlined in #78 |
Greetings,
I'm trying to use the Covalent components within my app using the NPM packages but I'm having a problem. The component's code is already transpiled to Javascript but the styles and templates were not converted to a inline version inside the Javascript file. As a result, when I use the components, the loader does not find the styles and templates.
The Angular Material 2 NPM packages algo have the transpiled versions, but the templates and styles are inlined.
I'm using webpack to bundle and did not found a work around this problem. Do you have any thoughts about how this can be solved, or could you provide the inlined versions in a future release?
Regards
The text was updated successfully, but these errors were encountered: