You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apparently, Covalent Simple dialogs do not support word-wrapping on strings that contain very long words (without spaces). A word longer than certain threshold (lower case: about 50, Upper case: about 40 characters) cases the dialog to start displaying a vertical scroll bar.
While you usually have shorted words that say 40 characters, sometimes the application is displaying some kind of technical information (e.g. database table name, MQ queue name etc), which can exceed the threshold, after which it is not displayed correctly.
While one can argue this is not a bug, please consider the behaviour of a standard JavaScript 'alert()' method call, where even long words are wrapped properly.
I would expect something similar to happen when using Covalent Simple dialogs.
The following piece of code reproduces the behaviour -- again a ridiculously long string is not very common, but definitely can happen:
Dialogs should break extreme long words into multiple lines similarly to a standard alert() call
And/Or dialogs should be sizeable from the API so as to be able to accommodate long content.
What is the motivation / use case for changing the behavior?
I had a case, where I wanted to display a confirmation dialog containing a technical / system generated name. The content was not visible in the dialog. I myself had to write the logic to add spaces to into long strings so that the dialog show them properly.
Which version of Angular and Material, and which browser and OS does this issue affect?
All versions affected AFAIK.
Did this work in previous versions of Angular / Material?
Other information
The text was updated successfully, but these errors were encountered:
…ig (closes#1011) (#1059)
* feat(dialogs): extend MatDialogConfig to leverage all the dialog configurations
we are going away from hardcoding widths so this is technically a breaking change, but now you will be able to pass any widths and update the dialog configuration as needed.. also long words wrap properly
* feat(): add 400px width by default
…ig (closesTeradata#1011) (Teradata#1059)
* feat(dialogs): extend MatDialogConfig to leverage all the dialog configurations
we are going away from hardcoding widths so this is technically a breaking change, but now you will be able to pass any widths and update the dialog configuration as needed.. also long words wrap properly
* feat(): add 400px width by default
Do you want to request a feature or report a bug?
Reporting a bug.
Feature Request
Bug Report
Apparently, Covalent Simple dialogs do not support word-wrapping on strings that contain very long words (without spaces). A word longer than certain threshold (lower case: about 50, Upper case: about 40 characters) cases the dialog to start displaying a vertical scroll bar.
While you usually have shorted words that say 40 characters, sometimes the application is displaying some kind of technical information (e.g. database table name, MQ queue name etc), which can exceed the threshold, after which it is not displayed correctly.
While one can argue this is not a bug, please consider the behaviour of a standard JavaScript 'alert()' method call, where even long words are wrapped properly.
I would expect something similar to happen when using Covalent Simple dialogs.
The following piece of code reproduces the behaviour -- again a ridiculously long string is not very common, but definitely can happen:
On Chrome, for instance, the following JavaScript code displays an alert box with the text broken into multiple lines.
StackBlitz template: https://stackblitz.com/edit/covalent
Plunker template: http://plnkr.co/edit/7uZQn4mLNJkL6XN9WSNd
Screenshots or link to CodePen/Plunker/JSfiddle
What is the expected behavior?
alert()
callWhat is the motivation / use case for changing the behavior?
I had a case, where I wanted to display a confirmation dialog containing a technical / system generated name. The content was not visible in the dialog. I myself had to write the logic to add spaces to into long strings so that the dialog show them properly.
Which version of Angular and Material, and which browser and OS does this issue affect?
All versions affected AFAIK.
Did this work in previous versions of Angular / Material?
Other information
The text was updated successfully, but these errors were encountered: