Skip to content

Commit

Permalink
chore(): deprecate forRoot() from covalent. (closes #306) (#389)
Browse files Browse the repository at this point in the history
* chore(): deprecate forRoot() in markdown module

* chore(): deprecate forRoot() in highlight module

* chore(): deprecate forRoot in dynamic forms module

* chore(): deprecate forRoot in chips module

* chore(): deprecate forRoot in common module

* chore(): deprecate forRoot() in data table module

* chore(): deprecate forRoot in dialog module

* chore(): deprecate forRoot in expansion panel module

* chore(): deprecate forRoot in file module

* chore(): deprecate forRoot in json-formatter

* chore(): deprecate forRoot in menu module

* chore(): deprecate forRoot in notifications module

* chore(): deprecate forRoot in paging module

* chore(): deprecate forRoot in search module

* chore(): deprecate forRoot in steps module

* chore(): deprecate forRoot in layout module

* chore(): deprecate forRoot in loading module

* chore(): deprecate forRoot in media module

* chore(): deprecate forRoot in core module

* chore(): update docs and remove all forRoot() usage

its been deprecated by material and now by us
  • Loading branch information
emoralesb05 authored Mar 9, 2017
1 parent d6b62e4 commit 3cea292
Show file tree
Hide file tree
Showing 65 changed files with 779 additions and 160 deletions.
8 changes: 4 additions & 4 deletions docs/GETTING_STARTED.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ import { CovalentDynamicFormsModule } from '@covalent/dynamic-forms';
// other imports
@NgModule({
imports: [
CovalentCoreModule.forRoot(),
CovalentCoreModule,
// (optional) Additional Covalent Modules imports
CovalentHttpModule.forRoot(),
CovalentHighlightModule.forRoot(),
CovalentMarkdownModule.forRoot(),
CovalentDynamicFormsModule.forRoot(),
CovalentHighlightModule,
CovalentMarkdownModule,
CovalentDynamicFormsModule,
],
...
})
Expand Down
8 changes: 4 additions & 4 deletions src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ import { getSelectedLanguage, createTranslateLoader } from './utilities/translat
BrowserModule,
HttpModule,
JsonpModule,
CovalentCoreModule.forRoot(),
CovalentCoreModule,
CovalentHttpModule.forRoot(),
CovalentHighlightModule.forRoot(),
CovalentMarkdownModule.forRoot(),
CovalentDynamicFormsModule.forRoot(),
CovalentHighlightModule,
CovalentMarkdownModule,
CovalentDynamicFormsModule,
TranslateModule.forRoot({
loader: {
provide: TranslateLoader,
Expand Down
Loading

0 comments on commit 3cea292

Please sign in to comment.