Skip to content

Commit

Permalink
fix(steps): issue margin-inline style in certain conditions. (closes #…
Browse files Browse the repository at this point in the history
…501) (#503)

* fix(steps): issue margin-inline style in certain conditions

instead of using margin-inline-start or margin-inline-end, its better to just use proper styles depending on ltr or rtl

* fix(): set proper style for not(dir="rtl") cases

* fix(): added auto styles for line
  • Loading branch information
emoralesb05 authored Apr 12, 2017
1 parent dc56437 commit 193bc90
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 7 deletions.
20 changes: 16 additions & 4 deletions src/platform/core/steps/step-header/step-header.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,24 @@ $step-circle: 24px;
font-size: 0;
}
.td-circle,
.td-triangle,
.td-complete {
margin-inline-start: 8px;
font-size: 14px;
/deep/ :not([dir='rtl']) & {
margin: {
left: 8px;
right: 0px;
}
}
/deep/ [dir='rtl'] & {
margin: {
left: 0px;
right: 8px;
}
}
}
.td-triangle {
margin-inline-start: 8px;
.td-circle,
.td-complete {
font-size: 14px;
}
.td-step-label-wrapper {
padding-left: 8px;
Expand Down
19 changes: 16 additions & 3 deletions src/platform/core/steps/steps.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,27 @@
height: 1px;
position: relative;
top: 36px;
margin-inline-start: -6px;
margin-inline-end: -3px;
/deep/ :not([dir='rtl']) & {
left: -6px;
right: -3px;
}
/deep/ [dir='rtl'] & {
left: -3px;
right: -6px;
}
min-width: 15px;
}

.td-vertical-line {
position: absolute;
margin-inline-start: 20px;
/deep/ :not([dir='rtl']) & {
left: 20px;
right: auto;
}
/deep/ [dir='rtl'] & {
left: auto;
right: 20px;
}
bottom: -16px;
top: -16px;
border-left-width: 1px;
Expand Down

0 comments on commit 193bc90

Please sign in to comment.