Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General ダイアログのドロップダウンリストの内容が二重になる #288

Closed
sempreff opened this issue Aug 25, 2024 · 2 comments
Closed

General ダイアログのドロップダウンリストの内容が二重になる #288

sempreff opened this issue Aug 25, 2024 · 2 comments
Labels
bug Something isn't working
Milestone
5.3

Comments

@sempreff
Copy link
Contributor

概要

ExeDir と HomeDir が同じ場合、General ダイアログのドロップダウンリストの内容が二重になります。

再現手順

  1. portable.ini を置きます。
  2. Setup -> General... で General ダイアログを出します。
  3. LaunguageUI のドロップダウンリストの内容が二重になっています。

修正案

単純に、パスが同じなら二回見に行かないのが良いと思います。 #287 です。
@nmaya nmaya added the bug Something isn't working label Aug 25, 2024
@nmaya nmaya added this to the 5.3 milestone Aug 25, 2024
@nmaya nmaya closed this as completed Aug 25, 2024
@nmaya
Copy link
Member

nmaya commented Aug 25, 2024

マージしました。

@nmaya nmaya mentioned this issue Aug 25, 2024
Open
20 tasks
zmatsuo added a commit that referenced this issue Aug 25, 2024
@zmatsuo
strcmp() を wcscmp() に置き換え #288
05fc1c3 
- warning C4133: '関数': 'wchar_t *' と 'const char *' の間で型に互換性がありません。
- a5dc16c
@zmatsuo
Copy link
Member

zmatsuo commented Aug 25, 2024

char ではなく wchar_t 文字列なので、比較を wcscmp() に置き換えました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.3
Development

No branches or pull requests
3 participants
@nmaya @zmatsuo @sempreff