Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fixes #6

Merged
merged 11 commits into from
Apr 2, 2024
Merged

Audit fixes #6

merged 11 commits into from
Apr 2, 2024

Conversation

kyriediculous
Copy link
Member

  • Fix floating pragma
  • Fix open TODOs
  • Implement linear withdrawal delay
  • Throw error when result of _calculateShares() is 0 shares
  • Fix possible overwrite in UnlockQueue::push

adsiko
adsiko approved these changes Apr 1, 2024
View reviewed changes
Copy link

@adsiko adsiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kyriediculous kyriediculous merged commit 9e1cef9 into main Apr 2, 2024
3 checks passed
@kyriediculous kyriediculous deleted the nv/audit-fixes branch April 2, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adsiko adsiko adsiko approved these changes

@kaizu-xyz kaizu-xyz Awaiting requested review from kaizu-xyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyriediculous @adsiko