Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Agent 额外配置目录支持 #1756

Closed
ZhuoZhuoCrayon opened this issue Aug 21, 2023 · 4 comments
Closed

[FEATURE] Agent 额外配置目录支持 #1756

ZhuoZhuoCrayon opened this issue Aug 21, 2023 · 4 comments
Assignees
Labels
done 已上线到正式环境并验收通过 kind/feature 功能

Comments

@ZhuoZhuoCrayon
Copy link
Member

ZhuoZhuoCrayon commented Aug 21, 2023

背景

为什么需要

自定义参数放置在额外配置目录下,防止重装 / 配置重载场景下,由于节点管理未感知该特殊配置,而进行覆盖

功能

你想要什么功能

功能实现

建议的方案

目录格式:

Linux:/etc/sysconfig/gse/${环境代号,默认为 bk}/user_conf/
Windows: C:\\Windows\\System32\\config\\gse\\${环境代号,默认为 bk}\\user_conf

/etc/sysconfig/gse/${环境代号,默认为 bk} 从环境变量 GSE_ENVIRON_WIN_DIR 中读取
C:\\Windows\\System32\\config\\gse\\${环境代号,默认为 bk} 从环境变量 GSE_ENVIRON_DIR 中读取

现状是读取不到时,默认值时空串,此处需要添加默认值

image

生成命令创建:apps/backend/agent/solution_maker.py Line 376

实现方案

功能自测

代码变更覆盖功能点需要自测并截图

功能点 1 - Agent (Linux and Windows)安装时,目录自动创建

描述代码变更涉及功能点及自测截图

功能点 2 - 该配置渲染到 Agent(linux & Windows) 配置中的 extra_config_directory

描述代码变更涉及功能点及自测截图

...

@ZhuoZhuoCrayon ZhuoZhuoCrayon added kind/feature 功能 backlog 需求初始状态,等待产品进行评估 labels Aug 21, 2023
@CohleRustW
Copy link
Collaborator

步骤

  1. 增加企业版默认值兜底未配置环境变量
  2. 创建依赖目录时增加 settings.GSE_ENVIRON_DIR OR settings.GSE_ENVIRON_WIN_DIR
  3. 渲染实际的配置 extra_config_directory
image

@CohleRustW
Copy link
Collaborator

自测

  1. 老版本不增加选择依赖和渲染逻辑
image image
  1. gse 2.0增加渲染逻辑和依赖目录创建
  • linux
image image
  • windows
image image image

CohleRustW added a commit to CohleRustW/bk-nodeman that referenced this issue Aug 29, 2023
CohleRustW added a commit to CohleRustW/bk-nodeman that referenced this issue Aug 29, 2023
@CohleRustW CohleRustW added doing 已经接受处理,正在开发实验 for gray 可以在灰度/预发布环境验收 and removed backlog 需求初始状态,等待产品进行评估 doing 已经接受处理,正在开发实验 labels Aug 29, 2023
CohleRustW added a commit to CohleRustW/bk-nodeman that referenced this issue Aug 30, 2023
@ZhuoZhuoCrayon ZhuoZhuoCrayon added for test 可以在测试环境进行验收 and removed for gray 可以在灰度/预发布环境验收 labels Sep 5, 2023
CohleRustW added a commit to CohleRustW/bk-nodeman that referenced this issue Sep 6, 2023
@CohleRustW
Copy link
Collaborator

重载配置测试补充

image

@wyyalt wyyalt added the todo 进入开发排期的状态,纳入了最近的迭代 label Sep 15, 2023
@wyyalt wyyalt removed the todo 进入开发排期的状态,纳入了最近的迭代 label Sep 15, 2023
@CohleRustW
Copy link
Collaborator

sprintfix 调整

image image

@wyyalt wyyalt added tested 已经在测试环境验收通过 and removed for test 可以在测试环境进行验收 labels Sep 21, 2023
@wyyalt wyyalt added done 已上线到正式环境并验收通过 and removed tested 已经在测试环境验收通过 labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done 已上线到正式环境并验收通过 kind/feature 功能
Projects
Status: Done
Development

No branches or pull requests

3 participants