Merge pull request #39 from wklken/ft_new_eval

docs(condition/translate): add comment for starts_with translate
TencentBlueKing · Oct 29, 2021 · 4771d1c · 4771d1c
2 parents 9a79a2e + 0afc611
commit 4771d1c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/abac/pdp/condition/string_prefix.go b/pkg/abac/pdp/condition/string_prefix.go
@@ -58,12 +58,17 @@ func (c *StringPrefixCondition) Eval(ctx types.EvalContextor) bool {
 		return strings.HasPrefix(aStr, bStr)
 	})
 }
+
 func (c *StringPrefixCondition) Translate(withSystem bool) (map[string]interface{}, error) {
 	key := c.Key
 	if !withSystem {
 		key = removeSystemFromKey(key)
 	}
 
+	// NOTE: starts_with/ends_with/not_starts_with/not_ends_with should be
+	// 1. single value like: a starts_with x
+	// 2. multiple value like: a starts_with x OR a starts_with y
+	// NEVER BE `a starts_with [x, y]`
 	content := make([]map[string]interface{}, 0, len(c.Value))
 	for _, v := range c.Value {
 		content = append(content, map[string]interface{}{