feat：保存流水线时，校验是否有子流水线循环依赖 #10479 #10794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hejieehe
requested review from
irwinsun,
mingshewhe,
stubenhuang,
royalhuang,
randychen2046 and
tangruotian
as code owners
|
|
…o feat_10479 # Conflicts: # src/backend/ci/core/common/common-pipeline/src/main/kotlin/com/tencent/devops/common/pipeline/extend/ModelCheckPlugin.kt # src/backend/ci/core/process/api-process/src/main/kotlin/com/tencent/devops/process/constant/ProcessMessageCode.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/atom/plugin/IElementBizPluginService.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/atom/plugin/MarketBuildAtomElementBizPlugin.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/atom/plugin/MarketBuildLessAtomElementBizPlugin.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/atom/plugin/SubPipelineCallElementBizPlugin.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/extend/DefaultModelCheckPlugin.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/service/PipelineRepositoryService.kt # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/plugin/ElementBizPlugin.kt # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/plugin/trigger/element/TimerTriggerElementBizPlugin.kt # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/service/SubPipelineElementBizPluginService.kt # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/service/SubPipelineStartUpService.kt # src/backend/ci/core/process/biz-process/src/main/kotlin/com/tencent/devops/process/webhook/WebHookTriggerElementBizPlugin.kt
mingshewhe
requested changes
Oct 11, 2024
.../biz-process/src/main/kotlin/com/tencent/devops/process/service/SubPipelineStartUpService.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/tencent/devops/process/engine/listener/pipeline/MQPipelineCreateListener.kt
Show resolved
Hide resolved
…o feat_10479 # Conflicts: # support-files/i18n/process/message_en_US.properties # support-files/i18n/process/message_zh_CN.properties
mingshewhe
requested changes
Nov 22, 2024
| @Consumes(MediaType.APPLICATION_JSON) | ||
| interface OpSubPipelineRefResource { | ||
|
|
||
| @Operation(summary = "更新Agent流水线引用信息") |
| @@ -457,6 +459,13 @@ class PipelineVersionFacadeService @Autowired constructor( | |||
| pipelineId = pipelineId, | |||
| staticViewIds = request.staticViews | |||
| ) | |||
| // 更新子流水线插件引用信息 | |||
There was a problem hiding this comment.
这段代码不应该写在这里，应该写在com.tencent.devops.process.engine.service.PipelineRepositoryService.update和com.tencent.devops.process.engine.service.PipelineRepositoryService.create中，update时只有是正式版本才去更新
| `PIPELINE_NAME` VARCHAR(256) DEFAULT NULL COMMENT '流水线名称', | ||
| `CHANNEL` VARCHAR(32) DEFAULT NULL COMMENT '流水线渠道', | ||
| `CONTAINER_NAME` VARCHAR(256) DEFAULT NULL COMMENT 'JOB名称', | ||
| `SUB_PIPELINE_NAME` VARCHAR(256) DEFAULT NULL COMMENT '插件名称', |
| `SUB_PIPELINE_ID` VARCHAR(64) DEFAULT NULL COMMENT '子流水线流水线ID', | ||
| `PIPELINE_NAME` VARCHAR(256) DEFAULT NULL COMMENT '流水线名称', | ||
| `CHANNEL` VARCHAR(32) DEFAULT NULL COMMENT '流水线渠道', | ||
| `CONTAINER_NAME` VARCHAR(256) DEFAULT NULL COMMENT 'JOB名称', |
| `TASK_PIPELINE_TYPE` VARCHAR(64) DEFAULT NULL COMMENT '插件参数_引用类型', | ||
| `TASK_PIPELINE_ID` VARCHAR(256) DEFAULT NULL COMMENT '插件参数_流水线ID', | ||
| `TASK_PIPELINE_NAME` VARCHAR(256) DEFAULT NULL COMMENT '插件参数_流水线名称', | ||
| `CONTAINER_SEQ` VARCHAR(100) DEFAULT NULL COMMENT '插件序号', |
| `PROJECT_ID` VARCHAR(64) NOT NULL COMMENT '蓝盾项目ID', | ||
| `PIPELINE_ID` VARCHAR(64) NOT NULL COMMENT '蓝盾流水线ID', | ||
| `TASK_ID` VARCHAR(64) NOT NULL COMMENT 'TASK_ID', | ||
| `STAGE_NAME` VARCHAR(64) DEFAULT NULL COMMENT 'STAGE名称', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10479