Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix reporting bug when port is -1. #1038

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

SkyeBeFreeman
Copy link
Collaborator

@SkyeBeFreeman SkyeBeFreeman commented Jun 21, 2023

PR Type

Bugfix.

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

fixes #981

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2020.0.
  • Will pull request to branch of 2022.0.

@SkyeBeFreeman SkyeBeFreeman added this to the 1.12.0 milestone Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1038 (e32a38b) into 2021.0 (0dd00d5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             2021.0    #1038      +/-   ##
============================================
+ Coverage     83.08%   83.11%   +0.02%     
- Complexity     1615     1619       +4     
============================================
  Files           240      240              
  Lines          5340     5354      +14     
  Branches        625      627       +2     
============================================
+ Hits           4437     4450      +13     
- Misses          550      551       +1     
  Partials        353      353              
Impacted Files Coverage Δ
...oud/rpc/enhancement/feign/EnhancedFeignClient.java 100.00% <100.00%> (ø)
.../rpc/enhancement/plugin/EnhancedPluginContext.java 100.00% <100.00%> (ø)
.../resttemplate/EnhancedRestTemplateInterceptor.java 100.00% <100.00%> (ø)
...c/enhancement/scg/EnhancedGatewayGlobalFilter.java 97.36% <100.00%> (+0.14%) ⬆️
...lient/EnhancedWebClientExchangeFilterFunction.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@SkyeBeFreeman SkyeBeFreeman merged commit 6264476 into Tencent:2021.0 Jun 25, 2023
@SkyeBeFreeman SkyeBeFreeman deleted the 2021/fix_no_port_report branch June 25, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR-1001(API_INVALID_ARGUMENT): port value should be in range (0, 65536)
2 participants