fix(core): LayoutInflater.getFactory()行为保持和正常app一致 #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppCompat有一个installViewFactory逻辑，依赖于判断layoutInflater.getFactory() == null才正常安装。 而ShadowLayoutInflater已经设置了Factory，所以对于插件代码来说，虽然还能够setFactory， 但是getFactory()返回的就不是null了。 添加一个Transform，将插件中原本的getFactory()修改为ShadowLayoutInflater.getOriginalFactory， 从而保持插件代码getFactory()时总能获取到自己原本设置的Factory。 fix Tencent#214
shifujun
force-pushed
the
issue214
branch
2 times, most recently
from
c67d462 to
eb0a0f4
Compare
|
ReactiveCircus/android-emulator-runner#160 Android自动化测试暂时挂了。在本地测了没问题。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppCompat有一个installViewFactory逻辑，依赖于判断layoutInflater.getFactory() == null才正常安装。
而ShadowLayoutInflater已经设置了Factory，所以对于插件代码来说，虽然还能够setFactory，
但是getFactory()返回的就不是null了。
添加一个Transform，将插件中原本的getFactory()修改为ShadowLayoutInflater.getOriginalFactory，
从而保持插件代码getFactory()时总能获取到自己原本设置的Factory。
fix #214