Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chart label formatting and pagination strategy #979

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: chart label formatting and pagination strategy #979

merged 3 commits into from
Apr 2, 2024

Conversation

pocin
Copy link
Contributor

@pocin pocin commented Mar 4, 2024

Description

What does this PR solve?

Fixes # (issue)

Checklist

  • Code follows the style guide
  • I have performed a self-review of my own code
  • New and existing tests pass locally
  • This PR is targeting the correct branch

@pocin pocin requested a review from a team as a code owner March 4, 2024 11:52
@pocin pocin linked an issue Mar 4, 2024 that may be closed by this pull request
fix dashboard net debt metric formatting #978
Closed
@pocin pocin added the preview-deploy PRs tagged with this will get a preview deployment label Mar 4, 2024
@github-actions github-actions bot added the dapp dapp related issues/PRs label Mar 4, 2024
@nichosystem
Copy link
Contributor

nichosystem commented Mar 4, 2024 •
edited
Loading

Deploy preview for core ready!

✅ Preview
https://core-3vn69yomq-templedao.vercel.app
https://pr-979-preview.templedao.link

Built with commit 84beb6a.
This pull request is being automatically deployed with vercel-action

frontier159
frontier159 previously approved these changes Mar 5, 2024
View reviewed changes
@pocin
Copy link
Contributor Author

pocin commented Mar 11, 2024

  1. individual debt tokens (unformatted)
Screenshot 2024-03-11 at 11 29 33 2) netDebt metric (updated to stay consistent with the other metrics) Screenshot 2024-03-11 at 11 29 23 3) TRV Screenshot 2024-03-11 at 11 29 12

cc @medariox as per our latest discussion

@pocin pocin force-pushed the 978-fix-dashboard-net-debt-metric-formatting branch from 924250a to ed5366b Compare April 2, 2024 08:51
@pocin
Copy link
Contributor Author

pocin commented Apr 2, 2024

@medariox can you give me final approval? had to rebase

medariox
medariox previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pocin pocin changed the title fix: formatting debtUSD and creditUSD chart label fix: chart label formatting and pagination strategy Apr 2, 2024
@pocin pocin force-pushed the 978-fix-dashboard-net-debt-metric-formatting branch from ad01c1c to 12b2033 Compare April 2, 2024 11:07
@pocin pocin merged commit 7e5f990 into stage Apr 2, 2024
3 checks passed
@pocin pocin deleted the 978-fix-dashboard-net-debt-metric-formatting branch April 2, 2024 11:54
marshall2112 added a commit that referenced this pull request Apr 2, 2024
@marshall2112
Merge pull request #1004 from TempleDAO/stage
8466e5e 
fix:  chart label formatting and pagination strategy (#979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medariox medariox medariox approved these changes

@frontier159 frontier159 frontier159 left review comments

Assignees
No one assigned
Labels
dapp dapp related issues/PRs preview-deploy PRs tagged with this will get a preview deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix dashboard net debt metric formatting
4 participants
@pocin @nichosystem @medariox @frontier159