Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fostrich safe admin page #935

Merged
merged 20 commits into from
Apr 3, 2024
Merged

Fostrich safe admin page #935

merged 20 commits into from
Apr 3, 2024

Conversation

frost-ostrich
Copy link
Collaborator

@frost-ostrich frost-ostrich commented Dec 20, 2023 •
edited
Loading

Description

Add a Safe admin page which acts as backup when the Safe App ui goes offline.

The preview of this admin page can be accessed in https://pr-935-preview.templedao.link/safe

Checklist

  • Code follows the style guide
  • I have performed a self-review of my own code
  • New and existing tests pass locally
  • This PR is targeting the correct branch

@frost-ostrich frost-ostrich added the preview-deploy PRs tagged with this will get a preview deployment label Dec 20, 2023
@frost-ostrich frost-ostrich requested a review from a team as a code owner December 20, 2023 01:49
@github-actions github-actions bot added the dapp dapp related issues/PRs label Dec 20, 2023
@nichosystem
Copy link
Contributor

nichosystem commented Dec 20, 2023 •
edited
Loading

Deploy preview for core ready!

✅ Preview
https://core-8oxh31h2g-templedao.vercel.app
https://pr-935-preview.templedao.link

Built with commit 8252231.
This pull request is being automatically deployed with vercel-action

mountainpath9
mountainpath9 reviewed Jan 11, 2024
View reviewed changes
protocol/package.json Outdated Show resolved Hide resolved
protocol/scripts/generateTypechainFiles.ts Outdated Show resolved Hide resolved
apps/dapp/src/constants/env/production.tsx Outdated Show resolved Hide resolved
apps/dapp/src/components/Pages/Safe/admin/SafeTxDataTable.tsx Outdated Show resolved Hide resolved
apps/dapp/src/safe/open-api/use-safe-open-api.tsx Outdated Show resolved Hide resolved
apps/dapp/src/safe/sdk/contracts/safeDeploymentContracts.ts Show resolved Hide resolved
apps/dapp/src/safe/sdk/signatures/SafeSignature.ts Show resolved Hide resolved
apps/dapp/src/safe/sdk/signatures/utils.ts Show resolved Hide resolved
apps/dapp/src/safe/sdk/transactions/gas.ts Show resolved Hide resolved
apps/dapp/src/safe/sdk/use-safe-sdk.tsx Show resolved Hide resolved
@mountainpath9
Copy link
Collaborator

Actually, rather than adding comments in every file in safe/sdk, perhaps a README file that that provides a list of the files from which the code was sourced?

@mountainpath9
Copy link
Collaborator

This needs a review from one of the core devs more familar with the temple dapp codebase.

@frontier159 frontier159 added preview-deploy PRs tagged with this will get a preview deployment and removed preview-deploy PRs tagged with this will get a preview deployment labels Jan 17, 2024
@frost-ostrich frost-ostrich force-pushed the fostrich-safe-admin-page branch 2 times, most recently from 4c95834 to 0f47cea Compare January 19, 2024 21:21
@frost-ostrich frost-ostrich force-pushed the fostrich-safe-admin-page branch 2 times, most recently from d3fd960 to dc0a7e2 Compare February 16, 2024 20:44
@frost-ostrich
feat: add safe admin page draft
a23e7e6
@frost-ostrich
feat: safe admin page working
2181baa
@frost-ostrich
wip: add sign & execute safe tx without sdk
4f0430f
@frost-ostrich
feat: safe admin page working without safe-sdk to solve yarn build de…
cfded22 
…pendencies issue
@frost-ostrich
chore: organize safe files & dirs
9f69b73
@frost-ostrich
chore: clean unused functions & constants
2871c7f
@frost-ostrich
chore: remove unnecessary safe test contract generation
13fdacd
@frost-ostrich
feat: use env list for multiple safe wallets management
22386bc
@frost-ostrich
docs: add source of safe sdk files copy
154255d
@frost-ostrich
refactor: update table rows name in safe table
3ce941c
@frost-ostrich
feat: track safe transaction status dinamically
2d6cb40
@frost-ostrich
feat: add mainnet multisig addresses & add script to replace host for…
054ef70 
… safe open api
@frost-ostrich
feat: safe transaction queue & history tables & row expanded addition…
ea4e0fa 
…al info & copy/link icons
@frost-ostrich
feat: add data raw & copy button to expanded row
b88d479
@frost-ostrich frost-ostrich force-pushed the fostrich-safe-admin-page branch 3 times, most recently from e0b4248 to 5999590 Compare April 3, 2024 17:59
@frost-ostrich frost-ostrich force-pushed the fostrich-safe-admin-page branch from 5999590 to 8252231 Compare April 3, 2024 18:01
@frost-ostrich frost-ostrich merged commit 686c325 into stage Apr 3, 2024
6 checks passed
@frost-ostrich frost-ostrich deleted the fostrich-safe-admin-page branch April 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichosystem nichosystem nichosystem left review comments

@frontier159 frontier159 frontier159 approved these changes

@mountainpath9 mountainpath9 Awaiting requested review from mountainpath9

Assignees
No one assigned
Labels
dapp dapp related issues/PRs preview-deploy PRs tagged with this will get a preview deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frost-ostrich @nichosystem @mountainpath9 @frontier159