tgld audit fix m08 #1033
Merged
tgld audit fix m08 #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
No token recover mechanism when the auction ends without any bid
Description
In SpiceAuction contract, when an auction ends with no bids, the auction tokens are locked into the contract and can't be recovered. recoverToken function doesn't help recover the auction token because it limits recoverable amount to
balance - totalAllocationImpact
It has Medium severity because the auction tokens can be stuck in the contract and can't be recovered, although this would be rare case.
Recommendation
There has to be a mechanism implemented to recover tokens from auctions when it ends without any bids.
Tag
tgld audit fix m08
Checklist