Add no-array-index-key eslint rule #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall2112
force-pushed
the
no-array-index-key
branch
4 times, most recently
from
26960f3 to
40dc3a8
Compare
marshall2112
force-pushed
the
no-array-index-key
branch
from
40dc3a8 to
4c1222c
Compare
marshall2112
added
the
preview-deploy
|
Deploy preview for core ready! ✅ Preview Built with commit 4c1222c. |
pocin
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the no-array-index-key lint rule, closing the last of the items in #904.
There are a couple places I added
eslint-disable-next-line react/no-array-index-keybecause I didn't think it was worth it to try to implement some convoluted key based on the existing data (e.g. rows of metrics). Happy to change if the reviewer think it's worth it.Checklist