Skip to content

Commit

Permalink
feat: address option label CRs
Browse files Browse the repository at this point in the history
  • Loading branch information
frost-ostrich committed Nov 15, 2023
1 parent 50c35c0 commit cbef461
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export const RowFilterDropdown = (props: Props) => {
<DropdownOptionsContainer ref={ref}>
{dropdownOptions.map((op, idx) => (
<DropdownOption key={idx} isChecked={op.checked}>
<RadioCheckbox
key={idx}
<RadioCheckbox
id={op.label}
defaultChecked={op.checked}
onClick={(e) => {
const target = e.target as HTMLInputElement;
Expand All @@ -54,7 +54,7 @@ export const RowFilterDropdown = (props: Props) => {
setDropdownOpened(!dropdownOpened);
}}
/>
<OptionLabel>{op.label}</OptionLabel>
<OptionLabel htmlFor={op.label}>{op.label}</OptionLabel>
</DropdownOption>
))}
</DropdownOptionsContainer>
Expand Down Expand Up @@ -85,6 +85,7 @@ function useOutsideClick(callback: () => void) {

const OptionLabel = styled.label`
vertical-align: super;
cursor: pointer;
`;

const DropdownOptionsContainer = styled.div`
Expand Down

0 comments on commit cbef461

Please sign in to comment.