Oud support #10
Merged
Oud support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shero0x1337
commented
Feb 10, 2023
shero0x1337
commented
- Support Multi-asset borrowing with different parameters
frontier159
reviewed
Feb 13, 2023
frontier159
requested changes
Feb 15, 2023
| event DepositDebt(uint256 amount); | ||
| event RemoveDebt(uint256 amount); | ||
| event SetCollateralPrice(TokenPrice price); | ||
| event SetDebtCollector(address debtCollector); |
There was a problem hiding this comment.
A lot of these should be indexed event params: https://docs.soliditylang.org/en/v0.8.18/contracts.html#events
There was a problem hiding this comment.
yeah ack. Let me think about the events i want to index a little bit more. Will add in a separate pr.
|
Merging for now to consolidate branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.